Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup sphinx for documentation #119

Closed
7 of 8 tasks
fyliu opened this issue Dec 19, 2022 · 3 comments
Closed
7 of 8 tasks

Setup sphinx for documentation #119

fyliu opened this issue Dec 19, 2022 · 3 comments
Assignees
Labels
complexity: missing feature: infrastructure For changes on site technical architecture feature: process improvement research Issue involving doing research role: missing s: PD team stakeholder: People Depot Team size: 3pt Can be done in 13-18 hours

Comments

@fyliu
Copy link
Member

fyliu commented Dec 19, 2022

Overview

As PeopleDepot and python developers, it helps to have well-organized documentation. We should set up sphinx for this purpose.

Sphinx is the standard documentation tool for python projects that supports many useful formatting elements. Furo is a clean theme with good layout, legible night mode. In the spirit of ease of use for the API developers, we should set up MyST parser for sphinx to support CommonMark markdown documentation rather than the default restructured-text. Devs can still use rST according to preference.

Action Items

  • setup sphinx doc tool
    • make note of any problems, and how to run it for development
  • setup MyST parser
    • make note of files changed to switch over to markdown
  • setup furo theme
  • setup automation to generate docs
    • document the action if it's custom
  • document how things work

Resources/Instructions

Sphinx
MyST parser
furo

potentially useful

sphinx tutorial

Discussion

There are several related suggestions here:

  • sphinx addresses the desire to use the documentation system of choice for python projects
    • it's useful to be familiar with it if contributors want to go on to a career working with python
    • it supports many useful formatting elements such as tabbed content
    • has many useful extensions
  • MyST parser addresses the concern that many current devs are more familiar with markdown than with restructured text
  • furo theme addresses more personal concerns
    • 3 column interface with page contents
    • clean and minimal, but not too spacious like material design
    • partly inspired by sphinx-book-theme, which is also very nice
    • uses sphinx-design, which provides ui elements like synchronized tabs and dropdowns
@fyliu fyliu added size: 3pt Can be done in 13-18 hours research Issue involving doing research labels Dec 19, 2022
@fyliu fyliu added documentation Improvements or additions to documentation size: 2pt Can be done in 7-12 hours role: repo feature: infrastructure For changes on site technical architecture feature: process improvement and removed size: 2pt Can be done in 7-12 hours documentation Improvements or additions to documentation labels Jan 6, 2023
@fyliu fyliu self-assigned this Jan 15, 2023
@fyliu
Copy link
Member Author

fyliu commented Feb 9, 2023

Status Update

  1. Progress - I setup an example at peopledepot.readthedocs.io. It has a few modifications as examples of the kind of things we can do with documentation to make it more clear and useful.
  2. Blockers - none
  3. Availability - at least 8 hours in the next 7 days
  4. ETA - It should take 4-5 hours

I was working on this before my ssd died a few weeks ago. Now I can continue.

These are the remaining things to do:

  1. Clean up the commits
  2. Add documentation

@fyliu
Copy link
Member Author

fyliu commented Feb 16, 2023

I'm still working on the documentation. It should be complete by next meeting.

@ExperimentsInHonesty ExperimentsInHonesty added this to the 5 - Team Workflow milestone Mar 5, 2023
@ExperimentsInHonesty ExperimentsInHonesty added role: missing s: PD team stakeholder: People Depot Team labels Mar 5, 2023
@ExperimentsInHonesty ExperimentsInHonesty added feature: infrastructure For changes on site technical architecture and removed feature: infrastructure For changes on site technical architecture labels Jun 29, 2023
@fyliu
Copy link
Member Author

fyliu commented Aug 4, 2023

This is not relevant anymore since we've decided to use mkdocs instead. Closing this issue

@fyliu fyliu closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
@shmonks shmonks moved this to Done in P: PD: Project Board Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: missing feature: infrastructure For changes on site technical architecture feature: process improvement research Issue involving doing research role: missing s: PD team stakeholder: People Depot Team size: 3pt Can be done in 13-18 hours
Projects
Status: ✅Done
Development

Successfully merging a pull request may close this issue.

2 participants