Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Send Suggestion Feature #1069

Closed
3 tasks
entrotech opened this issue Oct 26, 2021 · 4 comments · Fixed by #1085 or #1092
Closed
3 tasks

Fix Send Suggestion Feature #1069

entrotech opened this issue Oct 26, 2021 · 4 comments · Fixed by #1085 or #1092
Labels
P-Feature: Organizations Organization profile from the food seeker side Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Back-end Node/Express Development Task size: 2pt The lift to complete this user story 3-4hrs

Comments

@entrotech
Copy link
Member

entrotech commented Oct 26, 2021

Overview

If you attempt to Send a Suggestion (or Suggest a new Listing), when you Send the suggestion it fails with an HTTP 500 error.

Action Items

  • Debug and fix.
  • Change statuses to "New", "Pending", "Rejected", and "Closed"
  • Modify so suggestions are specific to a tenant (i.e., the suggestions for Los Angeles are independent of suggestions for Hawaii, McKinney, Santa Barbara, etc.)

Resources/Instructions

@entrotech entrotech added Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Back-end Node/Express Development Task size: 2pt The lift to complete this user story 3-4hrs P-Feature: Organizations Organization profile from the food seeker side labels Oct 26, 2021
@entrotech
Copy link
Member Author

@hanapotski I this @gigicobos created a wireframe for the Suggestion Admin page at one time - we should review to see if the implemented page matches, and consider creating a new feature for the new iteration on this feature.

@gigicobos
Copy link
Contributor

gigicobos commented Nov 5, 2021

@hanapotski Attached the wireframe for the Suggestions admin page. This wireframe includes the information we will need but as we discussed your layout looked cleaner and simpler. I do not have a the screenshot of the layout you shared with me. Hope this helps. Let me know if you have any questions.

Screen Shot 2021-11-04 at 11 16 13 PM

@entrotech
Copy link
Member Author

entrotech commented Nov 6, 2021

I worked on this a bit to get it functioning. I'd like to give this issue back to @hanapotski and @gigicobos to finalize the appearance and decide it we want to do another iteration on the feature. Here is what it looks like now:

image
A few things to think about:
The "Suggestions" come from two places, the Suggest New Listing feature on the Main Menu, which allows users to enter a bunch of details. If the suggested new listing is a good one, then the admin would want to create a new listing from the suggestions, so it might be good to have a button that the admin could press to start creating a new listing by going to the OrganizationEdit Screen, with the matching fields from the suggestion filled in. The admin could then finish the listing or assign it to a volunteer to verify.
The other place suggestions come from is the Send Correction button on the Organization Detail panel. In this case, if the admin decides the suggestion is good, would be to maybe attach the suggestion to the Organization Record in a new field for display in that Organization's Edit form, so the admin (or an assigned volunteer can see the suggestion and manually merge it with the existing information, save the changes, and "Close" the suggestion.
On the Suggestion Admin screen, it might be a good idea to show whether the suggestion is for a new listing or a correction to an existing listing..

@gigicobos
Copy link
Contributor

@hanapotski @entrotech will get the feedback from Jordan (and the other admin volunteers) about the features for next iteration. I will have comments / revised mockup after their feedback.
@entrotech would it be too much if we make sure the next iteration also includes the changes for issue #996 where pantries submit suggestions as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Feature: Organizations Organization profile from the food seeker side Release Note: Bug Something isn't working (Shows on release notes under "Bug Fixes") Role: Back-end Node/Express Development Task size: 2pt The lift to complete this user story 3-4hrs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants