From 572b6b76b397ba8455b58319c2bba22552350e4a Mon Sep 17 00:00:00 2001 From: Nicholas Kwon Date: Thu, 5 May 2022 15:48:01 -0700 Subject: [PATCH 1/6] Add engines block --- client/package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/client/package.json b/client/package.json index f51d7dc43..5c0499ad8 100644 --- a/client/package.json +++ b/client/package.json @@ -1,6 +1,9 @@ { "name": "311-data", "version": "0.1.0", + "engines": { + "node": "12.x" + }, "homepage": "https://www.311-data.org/", "dependencies": { "@react-pdf/renderer": "^1.6.8", From 4806f7db2637206d9516ec9626e71fa00cb9a4b7 Mon Sep 17 00:00:00 2001 From: Nicholas Kwon Date: Thu, 5 May 2022 14:39:33 -0700 Subject: [PATCH 2/6] Specify Node v12 --- .github/workflows/Continuous_Integration_Frontend.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Continuous_Integration_Frontend.yml b/.github/workflows/Continuous_Integration_Frontend.yml index 826450932..6d25cae82 100644 --- a/.github/workflows/Continuous_Integration_Frontend.yml +++ b/.github/workflows/Continuous_Integration_Frontend.yml @@ -10,10 +10,13 @@ defaults: working-directory: client jobs: - build: + ci_frontend_build: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 + - uses: actions/setup-node@v3 + with: + node-version: 12 - name: Install Packages run: npm install - name: Lint From a69aa0d538a55607f593ea8a0aee422267fb8f3c Mon Sep 17 00:00:00 2001 From: Nicholas Kwon Date: Thu, 5 May 2022 14:48:13 -0700 Subject: [PATCH 3/6] Also add on:workflow_dispatch for manual trigger --- .github/workflows/Continuous_Integration_Frontend.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Continuous_Integration_Frontend.yml b/.github/workflows/Continuous_Integration_Frontend.yml index 6d25cae82..dce16bc34 100644 --- a/.github/workflows/Continuous_Integration_Frontend.yml +++ b/.github/workflows/Continuous_Integration_Frontend.yml @@ -4,6 +4,7 @@ on: pull_request: paths: - 'client/**' + workflow_dispatch: defaults: run: From 71c848c271f409ae1361053422983aa9297dacb6 Mon Sep 17 00:00:00 2001 From: Nicholas Kwon Date: Thu, 5 May 2022 15:04:40 -0700 Subject: [PATCH 4/6] Also run Action when Action itself is modified --- .github/workflows/Continuous_Integration_Frontend.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/Continuous_Integration_Frontend.yml b/.github/workflows/Continuous_Integration_Frontend.yml index dce16bc34..1965bf3b8 100644 --- a/.github/workflows/Continuous_Integration_Frontend.yml +++ b/.github/workflows/Continuous_Integration_Frontend.yml @@ -4,6 +4,7 @@ on: pull_request: paths: - 'client/**' + -'.github/workflows/Continuous_Integration_Frontend.yml' workflow_dispatch: defaults: From 66ccd781158ae153d435cfa9fd150aa07035dcac Mon Sep 17 00:00:00 2001 From: Nicholas Kwon Date: Thu, 5 May 2022 15:07:06 -0700 Subject: [PATCH 5/6] Fix spacing --- .github/workflows/Continuous_Integration_Frontend.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Continuous_Integration_Frontend.yml b/.github/workflows/Continuous_Integration_Frontend.yml index 1965bf3b8..06fd12120 100644 --- a/.github/workflows/Continuous_Integration_Frontend.yml +++ b/.github/workflows/Continuous_Integration_Frontend.yml @@ -4,7 +4,7 @@ on: pull_request: paths: - 'client/**' - -'.github/workflows/Continuous_Integration_Frontend.yml' + - '.github/workflows/Continuous_Integration_Frontend.yml' workflow_dispatch: defaults: From f33ee65bb832d78efb8b14e67a0c720897b26c6d Mon Sep 17 00:00:00 2001 From: Nicholas Kwon Date: Sat, 7 May 2022 18:41:02 -0700 Subject: [PATCH 6/6] Add more setup node blocks --- .github/workflows/Continuous_Deployment_Frontend_Dev.yml | 7 ++++++- .github/workflows/Continuous_Deployment_Frontend_Prod.yml | 6 +++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/Continuous_Deployment_Frontend_Dev.yml b/.github/workflows/Continuous_Deployment_Frontend_Dev.yml index 20d92a3d1..c36afaf70 100644 --- a/.github/workflows/Continuous_Deployment_Frontend_Dev.yml +++ b/.github/workflows/Continuous_Deployment_Frontend_Dev.yml @@ -6,17 +6,22 @@ on: - dev paths: - 'client/**' + workflow_dispatch: defaults: run: working-directory: client jobs: - build: + deploy_frontend_dev: runs-on: ubuntu-latest steps: - name: Checkout Repository Code uses: actions/checkout@v1 + - name: Setup Node + uses: actions/setup-node@v3 + with: + node-version: 12 - name: Rebuild sass run: npm rebuild node-sass - name: Install Packages diff --git a/.github/workflows/Continuous_Deployment_Frontend_Prod.yml b/.github/workflows/Continuous_Deployment_Frontend_Prod.yml index 2bc3c9dc3..abaf67544 100644 --- a/.github/workflows/Continuous_Deployment_Frontend_Prod.yml +++ b/.github/workflows/Continuous_Deployment_Frontend_Prod.yml @@ -12,11 +12,15 @@ defaults: working-directory: client jobs: - build: + deploy_frontend_prod: runs-on: ubuntu-latest steps: - name: Checkout Repository Code uses: actions/checkout@v1 + - name: Setup Node + uses: actions/setup-node@v3 + with: + node-version: 12 - name: Rebuild sass run: npm rebuild node-sass - name: Install Packages