Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocoder search box #888

Closed
4 of 5 tasks
adamkendis opened this issue Jan 8, 2021 · 6 comments · Fixed by #1087
Closed
4 of 5 tasks

Geocoder search box #888

adamkendis opened this issue Jan 8, 2021 · 6 comments · Fixed by #1087
Assignees
Labels
Role: Frontend React front end work Size: 8pt Can be done in 31-48 hours

Comments

@adamkendis
Copy link
Member

adamkendis commented Jan 8, 2021

Description

Address search box for basic user menu.

Action Items

  • Add mapbox-gl-geocoder control to map for basic user menu
  • Map flyTo on successful geocode result.
  • Search by address.
  • Search by NC.
  • Limit bounds to LA.

Resources

https://docs.mapbox.com/mapbox-gl-js/example/mapbox-gl-geocoder/

Screen Shot 2021-02-15 at 3 33 08 PM

Screen Shot 2021-02-15 at 3 33 00 PM

@adamkendis adamkendis added Role: Frontend React front end work Needs More Info Request for more info...Issue not clear labels Jan 8, 2021
@adamkendis adamkendis added Size: 8pt Can be done in 31-48 hours and removed Needs More Info Request for more info...Issue not clear labels Feb 12, 2021
@adamkendis adamkendis added this to the Initial v2 Launch milestone Feb 12, 2021
@adamkendis adamkendis added Needs More Info Request for more info...Issue not clear and removed Needs More Info Request for more info...Issue not clear labels Feb 12, 2021
@mattyweb
Copy link
Collaborator

FYI, I created a ticket on the backend to get a lat and long and look up the NC from it. It's issue #957

I also think it would be great to use the browser location feature so users don't have to type in an address.

@mattyweb
Copy link
Collaborator

Question: what is the benefit of having the address search box be able to search by council name in addition to address? The neighborhood council names are not exactly easy to determine or remember. I would kind of assume that if someone knew the name of a council they'd know it's location on the map and it would be easier for them to click on it than type it in. do we have any data from v1 that says this is a useful feature? otherwise, it might be easiest for this to be a pure address search.

@adamkendis
Copy link
Member Author

I don't know of v1 data supporting council name search for the v2 basic user. A pure address search would definitely be easier.

@adamkendis
Copy link
Member Author

Address search bar redesigned to allow toggling between address and council search. See contemplated redesigns in Figma:
https://www.figma.com/file/eF63O8yIGz2soQ4JJFfyoK/311_Data_UXUI?node-id=2375%3A0

@adamkendis adamkendis mentioned this issue Mar 26, 2021
2 tasks
@adamkendis
Copy link
Member Author

adamkendis commented Apr 2, 2021

Status: Geocode address to lat/lng and fetching enclosing council id from API working. Still need to:

  • Style
  • Push to history on geocode result - map/nc/:nc_id or something similar.
  • NC localGeocoder
  • Switching between address/NC search

ETA: To be completed this weekend, 4/4.

@adamkendis adamkendis self-assigned this Apr 2, 2021
@adamkendis adamkendis mentioned this issue Apr 9, 2021
4 tasks
@adamkendis
Copy link
Member Author

Status: Wasn't able to finish up this past week. Address search merged to dev via #1081. Working on localGeocoder for searching by NC name.
ETA: By next meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Role: Frontend React front end work Size: 8pt Can be done in 31-48 hours
Projects
Development

Successfully merging a pull request may close this issue.

2 participants