Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter menu - bottom drawer (mobile) #833

Closed
6 tasks
adamkendis opened this issue Nov 3, 2020 · 7 comments
Closed
6 tasks

Filter menu - bottom drawer (mobile) #833

adamkendis opened this issue Nov 3, 2020 · 7 comments
Labels
P-feature: Mobile work done to make the site mobile accessible Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours

Comments

@adamkendis
Copy link
Member

adamkendis commented Nov 3, 2020

Description

This menu drawer will provide the primary map/visualizations controls for mobile.

See #832 for desktop menu.

Action Items

Don't implement the actual filter/selector controls under this ticket.

  • Implement sliding bottom drawer menu using material-ui Drawer component.
    • Functional component using React Hooks strongly encouraged.
    • Styling via one of material-ui's styling options.
    • Collapsed by default.
    • Open via tap or swipe up. (mobile)
    • Close via tap at the top or swipe down.

Resources

https://material-ui.com/components/drawers/
https://material-ui.com/styles/advanced/#makestyles

Screen Shot 2020-11-19 at 5 06 34 PM

Screen Shot 2020-11-19 at 5 06 43 PM

Screen Shot 2020-11-19 at 5 07 27 PM

@adamkendis adamkendis added Role: Frontend React front end work Needs More Info Request for more info...Issue not clear P-feature: Mobile work done to make the site mobile accessible labels Nov 3, 2020
@adamkendis adamkendis removed the Needs More Info Request for more info...Issue not clear label Nov 20, 2020
@adamkendis adamkendis added the Size: 2pt Can be done in 7-12 hours label Feb 15, 2021
@adamkendis adamkendis added this to the Initial v2 Launch milestone Feb 15, 2021
@adamkendis adamkendis added Size: 3pt Can be done in 13-18 hours and removed Size: 2pt Can be done in 7-12 hours labels Mar 26, 2021
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in X days.

@github-actions github-actions bot added the Stale label Jun 25, 2021
@adamkendis adamkendis self-assigned this Jul 23, 2021
@captain-nimo
Copy link
Member

@adamkendis
Please provide update:

  1. Progress
  2. Blocks
  3. Availability
  4. ETA

@github-actions github-actions bot removed the Stale label Aug 6, 2021
@adamkendis
Copy link
Member Author

Progress: Started a week ago.
Blocks: Have been blocked by work.
Availability: Will be working on it this weekend.
ETA: By next week.

@ExperimentsInHonesty
Copy link
Member

@adamkendis I am assuming you meant to close this issue. Please respond with why we closed it and use the Close with comment button

@adamkendis
Copy link
Member Author

adamkendis commented Dec 3, 2021

I have an in progress branch. Will push it up and pull in another dev to complete if I'm not able to in the next week or two.

EDIT: Just kidding, I thought I had an in progress branch but am not finding one. Moving this into backlog.

@EchoProject
Copy link
Contributor

@nichhk here's an issue related to the Map Menu for mobile. this may not be relevant with the menu re-design change coming. Please feel free to close if not needed, else we can add to the epic.

@nichhk
Copy link
Member

nichhk commented Oct 11, 2022

Hmm this looks like a pretty useful design for mobile. I'm not sure how compatible it is with the current design though. @melissahermes99, do you think this is helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Mobile work done to make the site mobile accessible Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours
Projects
Status: Done (without merge)
Development

No branches or pull requests

7 participants