Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite data service to utilize ORM features #398

Closed
2 tasks done
sellnat77 opened this issue Mar 9, 2020 · 0 comments
Closed
2 tasks done

Rewrite data service to utilize ORM features #398

sellnat77 opened this issue Mar 9, 2020 · 0 comments
Assignees
@jmensch1
Labels
Enhancement New feature or request Role: Backend Related to API or other server-side work v1 The first version of the site

Comments

@sellnat77
Copy link
Member

sellnat77 commented Mar 9, 2020 •
edited by jmensch1
Loading

Description

Current data service does string concatenation and if statements to generate query strings. Application should utilize the sqlalchemy ORM functions instead

Action Items

  • Rewrite dataservice.query() to use ORM
  • Rewrite implementing services to adjust the parameters passed in
@sellnat77 sellnat77 added Enhancement New feature or request Role: Backend Related to API or other server-side work labels Mar 9, 2020
@sellnat77 sellnat77 mentioned this issue Mar 9, 2020
Merged
@jmensch1 jmensch1 self-assigned this Mar 9, 2020
@github-project-automation github-project-automation bot moved this to Done (without merge) in P: 311: Project Board Aug 22, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the v1 The first version of the site label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmensch1 jmensch1

Labels
Enhancement New feature or request Role: Backend Related to API or other server-side work v1 The first version of the site
Projects
P: 311: Project Board
Status: Done (without merge)
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sellnat77 @jmensch1 @ExperimentsInHonesty @danarchen