Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateSelector - error handling #381

Closed
3 tasks
adamkendis opened this issue Mar 6, 2020 · 2 comments · Fixed by #535
Closed
3 tasks

DateSelector - error handling #381

adamkendis opened this issue Mar 6, 2020 · 2 comments · Fixed by #535
Assignees
@jmensch1
Labels
Role: Frontend React front end work v1 The first version of the site
Milestone
311 Data Alpha - ...

Comments

@adamkendis
Copy link
Member

#Description

Add better error handling/display to DateRangerPicker component. Remove the alert for when start/end date hasn't been selected.

Action Items

  • Remove alert('Provide valid start and end dates.')
  • Add error handling for when user clicks submit without valid start and/or end dates.
  • Change corresponding date input color on error. (bulma danger classname)
@adamkendis adamkendis added the Role: Frontend React front end work label Mar 6, 2020
@adamkendis adamkendis self-assigned this Mar 6, 2020
@adamkendis
Copy link
Member Author

I'll do this after I finish #332

@brodly
Copy link
Member

brodly commented Mar 14, 2020

Ticket #426 creates an error handling modal when a data request errors out. Might be able to use this modal to populate general UI errors as well. Should discuss this approach

@jmensch1 jmensch1 assigned jmensch1 and unassigned adamkendis Apr 12, 2020
@jmensch1 jmensch1 mentioned this issue Apr 12, 2020
Merged
4 tasks
@ExperimentsInHonesty ExperimentsInHonesty added the v1 The first version of the site label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmensch1 jmensch1

Labels
Role: Frontend React front end work v1 The first version of the site
Projects
P: 311: Project Board
Status: Done
Milestone
311 Data Alpha - Dev Complete
Development

Successfully merging a pull request may close this issue.

error handling in datepicker hackforla/311-data
4 participants
@jmensch1 @brodly @ExperimentsInHonesty @adamkendis