-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make font types in search and filters modal consistent #1815
Comments
Ready for dev lead. I think it's a "Good First Issue". Happy to add more in-depth instruction if required. |
Reviewing as dev lead: |
Updated Action Items with file loc, line, and implementation for "Boundaries" and "Date Range" titles in the search/filter map modal. Comment on my findings:Style implementation for each title is inconsistent across the 3 Titles in the modal. To introduce consistency, I've proposed a solution to use the IMPORTANT NOTE:Use style has been deprecated since 2021 and is now Legacy. It is not recommended for use. Issue created to address deprecated |
Updated the description a second-time. Issue previously did not update with the detailed action items points. |
This ticket has been prioritized and is ready to be picked up 👍 |
PR has been made: #1821 |
Overview
We need to make fonts on the search and filters modal consistent so users don't get confused about how the modal works
Action Items
Grab the color, font size, and font weight for "Request Types" in the Search and Filters Modal
/components/main/Desktop/TypeSelector/index.js
, line: 22, 83Apply that color, font size, and font weight to "Boundaries"
/components/main/Desktop/CouncilSelector/index.js
classes.label
toclasses.header
for "Boundaries" titleApply that color, font size, and font weight to "Date Range"
componenets/DataSelector/DataSelector.jsx
import useStyle from ...
import makeStyles from '@mui/styles/makeStyles';
span
todiv
for the title valueDate Range
className={label}
toclassName={classes.header}
Collapsible Sections
ADD: Header class style for "Boudaries"
DELETE: Label class style for "Boundaries"
ADD: useStyle const for "Date Range"
Resources/Instructions
Screenshot before proposed changes
Screenshot after proposed changes
![image](https://github.com/user-attachments/assets/85c9c00a-d0ca-45b7-9266-619fe71fa326)
The text was updated successfully, but these errors were encountered: