Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend is not compatible with Redux Devtools #1255

Closed
1 task
nichhk opened this issue Jun 22, 2022 · 3 comments
Closed
1 task

Frontend is not compatible with Redux Devtools #1255

nichhk opened this issue Jun 22, 2022 · 3 comments
Assignees
Labels
Feature: Optimization Role: Frontend React front end work Size: 8pt Can be done in 31-48 hours

Comments

@nichhk
Copy link
Member

nichhk commented Jun 22, 2022

Overview

Redux Devtools makes debugging and viewing redux state much simpler. We should make our frontend compatible with this extension. See this post for instructions.

It looks like we've installed and activated Redux Devtools two years ago (PR #289), but the extension is greyed out when I'm on the dev site.

Action Items:

  • We should rename "webpack.dev.js" to "webpack.local.js", and create a new "webpack.dev.js" file that is the same as "webpack.prod.js", but it specifies mode as "development". See context in comment below.
@nichhk nichhk self-assigned this Jun 22, 2022
@nichhk
Copy link
Member Author

nichhk commented Jun 23, 2022

Ah, so Redux Devtools only works locally because we're specifying development-only in the extension importing.

Currently, when we bring up the dev and v1 site, we are specifying that the mode is "production" (e.g., for dev, we run npm run build, and build uses the webpack.prod.js config). We should rename "webpack.dev.js" to "webpack.local.js", and create a new "webpack.dev.js" file that is the same as "webpack.prod.js", but it specifies mode as "development".

@nichhk nichhk added Role: Frontend React front end work Size: 2pt Can be done in 7-12 hours Size: 8pt Can be done in 31-48 hours and removed Size: 2pt Can be done in 7-12 hours labels Jul 19, 2022
@mc759
Copy link
Member

mc759 commented Dec 13, 2022

Hey @edwinjue can you help us update this issue?

Please update:

  • Progress:
  • Blockers:
  • Availability:
  • ETA:

Thanks!

@edwinjue
Copy link
Member

Redux devtools should already be working on local development environment as I already have it installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Optimization Role: Frontend React front end work Size: 8pt Can be done in 31-48 hours
Projects
Status: Done (without merge)
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants