Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC boundaries not rendering on dev site #1154

Closed
adamkendis opened this issue Nov 12, 2021 · 4 comments · Fixed by #1225
Closed

NC boundaries not rendering on dev site #1154

adamkendis opened this issue Nov 12, 2021 · 4 comments · Fixed by #1225
Assignees
Labels
Bug Something isn't working P-feature: Map Role: Backend Related to API or other server-side work Size: 3pt Can be done in 13-18 hours
Milestone

Comments

@adamkendis
Copy link
Member

Overview

When visiting dev.311-data.org, the boundaries do not render and the following error is logged in the console.
Error {message: 'Input data is not a valid GeoJSON object.'}

Action Items

  • Update with valid geojson.
@adamkendis adamkendis added Role: Backend Related to API or other server-side work Size: 3pt Can be done in 13-18 hours P-feature: Map labels Nov 12, 2021
@adamkendis adamkendis added this to the Initial v2 Launch milestone Nov 12, 2021
@adamkendis adamkendis added the Bug Something isn't working label Nov 12, 2021
@EchoProject
Copy link
Contributor

Hi @adamkendis should we keep this issue in the Icebox, or can we do an issue approval?

@EchoProject EchoProject modified the milestones: z.v2 Launch, 04-v2: Feature bugs Feb 5, 2022
@nichhk
Copy link
Member

nichhk commented May 20, 2022

This might be related to #1155--in order to do address searching, it seems like we need to be able to get the NC using the latitude and longitude of the address. I will try to fix this first before #1155.

@nichhk nichhk self-assigned this May 23, 2022
@nichhk
Copy link
Member

nichhk commented Jun 1, 2022

I've checked some of the GeoJSON files in client/v1/data, and they are indeed not valid GeoJSON files. geojsonlint.com points out several issues; however, even after using https://mapstertech.github.io/mapster-right-hand-rule-fixer/ to fix the issues (and now passing the linter), Error {message: 'Input data is not a valid GeoJSON object.'} persists.

@nichhk
Copy link
Member

nichhk commented Jun 1, 2022

I see now that the GeoJSON files might be getting pulled from the server? It is confusing because the client still references GeoJSON files from client/v1/data, but maybe we also need to update the GeoJSON files on the server-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working P-feature: Map Role: Backend Related to API or other server-side work Size: 3pt Can be done in 13-18 hours
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

3 participants