Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Disappearing NC Boundaries #1053

Closed
adamkendis opened this issue Mar 26, 2021 · 0 comments · Fixed by #1066
Closed

[BUG] Disappearing NC Boundaries #1053

adamkendis opened this issue Mar 26, 2021 · 0 comments · Fixed by #1066
Assignees
Labels
Bug Something isn't working Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours

Comments

@adamkendis
Copy link
Member

Describe the bug
BoundaryLayer is losing map context on subsequent renders. When navigating back to the map after visiting a non-map page, NC boundaries don't render.

Probably a good opportunity to improve map performance:

  • Instantiate shared mapbox instance outside of Map lifecycle methods.
  • follow v1 implementation for map/visualizations pages. Map never unmounts - visualizations page is displayed over the Map page. This will make switching back to the Map page instant with no re-render.

To Reproduce
Steps to reproduce the behavior:

  1. With client running locally, go to localhost:3000
  2. Wait for request dots and boundaries to load.
  3. Click any other link in header (any report, Contact Us, Blog)
  4. Click Map
  5. Request dots load but boundaries do not

Expected behavior
Boundaries display on subsequent renders.

Additional context

@adamkendis adamkendis added Bug Something isn't working Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours labels Mar 26, 2021
@adamkendis adamkendis added this to the Initial v2 Launch milestone Mar 26, 2021
@adamkendis adamkendis self-assigned this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours
Projects
Development

Successfully merging a pull request may close this issue.

1 participant