Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using githooks to avoid situations where we could expose credentials to github #22

Open
grymmy opened this issue Nov 8, 2023 · 5 comments

Comments

@grymmy
Copy link
Collaborator

grymmy commented Nov 8, 2023

It may be possible to use githooks to make it very hard to ever issue a commit on a repo that contains things that look like credentials. Please investigate the feasibility of this and, if possible, how we could provide broad protection re: this across all Hack Club repos.

@northeastprince
Copy link

What's the problem with just using push protection?

@grymmy
Copy link
Collaborator Author

grymmy commented Nov 9, 2023

@northeastprince seems like the right tool for the job tbh, and superior to just reliance on .gitignore, and would catch things hard-coded inline as well if I understand correctly. @JosiasAurel be aware

@JosiasAurel
Copy link
Contributor

super! I will investigate how to set this up.

@grymmy
Copy link
Collaborator Author

grymmy commented Dec 12, 2023

@JosiasAurel unassigned as this hasn't been moved forward in a while, and I don't think you're currently focusing on it - feel free to self-assign in the future again.

@JosiasAurel
Copy link
Contributor

JosiasAurel commented Aug 27, 2024

Do we enable Push protection organisation-wide or for specific repositories? GitHub has a default ruleset that includes Push protection for all repositories across the organisation (see https://github.com/organizations/hackclub/settings/security_products/configurations/view)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants