Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Profile page to match new designs #107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amit-sawhney
Copy link
Member

@amit-sawhney amit-sawhney commented Jul 15, 2021

Status:

🚀 Ready

Description

Reworking the profile page to match the new figma designs and abstracting the logic

Fixes #102

Todos

  • Abstract Profile content into component
  • Create a Modal version

Screenshots

image

@amit-sawhney amit-sawhney requested a review from Leundai July 15, 2021 03:34
@amit-sawhney amit-sawhney self-assigned this Jul 15, 2021
@vercel
Copy link

vercel bot commented Jul 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hack4impact/memberdb-tool/dC3j9iSpSwjDhnRge7CEYfB1Rxzr
✅ Preview: https://memberdb-tool-git-edit-member-display-hack4impact1.vercel.app

@amit-sawhney amit-sawhney marked this pull request as ready for review July 17, 2021 18:38
Copy link
Member

@Leundai Leundai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one quick thing it seems like the non-editable fields are barely readable on my screen. If we can darken the font color that might be helpful.

image

Also, make sure that the navbar changes are compatible with the new navbar.

Comment on lines +11 to +13
.profile-card .row {
/* padding-top: 30px !important; */
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this if it is not needed

Comment on lines +8 to +11
const Profile = () => (
<div className="profile-page">
<Page title="Profile">
<ProfileCard />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guccii stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul Edit Member Display
2 participants