Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundled zlib to 1.2.12 wheels once HDF5 is compatible #2081

Closed
takluyver opened this issue Apr 2, 2022 · 0 comments · Fixed by #2082
Closed

Upgrade bundled zlib to 1.2.12 wheels once HDF5 is compatible #2081

takluyver opened this issue Apr 2, 2022 · 0 comments · Fixed by #2082

Comments

@takluyver
Copy link
Member

In #2080, @matham found that HDF5 1.12.1 doesn't build with zlib 1.2.11. This is unfortunate, because there's a security issue fixed in zlib 1.2.12. Once there's a new release of HDF5, we should remember to upgrade the bundled zlib wherever we can - certainly this applies to at least the Mac wheels.

For Linux, it appears that we don't bundle zlib - it's now whitelisted in auditwheel as something you can assume will be on the system (pypa/auditwheel#152, pypa/auditwheel#334). So that's not our problem. 😃

For Windows, we get zlib from this nuget package, which is still on 1.2.11. Then again, 1.2.12 has only been out a few days, so it may just be a matter of waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant