-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "Look and feel > Theme color" triggers .h5p-invert-shades class, obscuring card content. #62
Comments
Hi! |
I should add that the content images on the card are text with transparent background. I could use an opaque image but I think the overlay would still go over that? |
OK, I'm starting to understand it better now. Sorry, I should have read your reply better. I was wrong, the pseudo element is not covering the img, it just appeared that way as the img is transparent. I can fix this by changing the theme colour to a much darker one or use an opaque image. This is probably an edge case but might be worth mentioning in the instructions? I'm happy to add a pull request for that if you want. I'm guessing https://github.com/h5p/h5p-memory-game/blob/master/semantics.json should be edited? |
Ah, yes, I'm glad you figured it out. |
Hi, I tried to change the "Theme color" in "Look and feel". This resulted in “.h5p-memory-game.h5p-invert-shades .h5p-memory-card .h5p-back:before” being added to the before pseudo element of the .h5p-back div. This covers the card content img with a #000 opacity 0.5 overlay which makes it hard to read the img. I also noticed that the selected theme color is added inline to the .h5p-back div but only on the "color" property. This won't therefore affect the cards (maybe it is for the description, I don't know). There is no way I can see of resetting the theme selection to prevent .h5p-invert-shades being added. So, if I want to fix the issue, I'd have to recreate the game again. Hope that helps. Cheers.
The text was updated successfully, but these errors were encountered: