Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated BrowseHappy prompt to be site-agnostic #1608

Closed
wants to merge 1 commit into from
Closed

Updated BrowseHappy prompt to be site-agnostic #1608

wants to merge 1 commit into from

Conversation

alilleybrinker
Copy link

Per the discussion in #1582, this simply replaces all explicit references to BrowseHappy with more site-agnostic wording.

@alilleybrinker alilleybrinker mentioned this pull request Sep 29, 2014
Closed
frenzzy
frenzzy reviewed Sep 30, 2014
View reviewed changes
src/index.html
@@ -15,7 +15,7 @@
</head>
<body>
<!--[if lt IE 8]>
<p class="browsehappy">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
<p class="browserupgrade">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@alrra
Copy link
Member

alrra commented Sep 30, 2014

Is everyone ok with this browserupgrade classname? Are there any other suggestions for the classname?

@battaglr
Copy link
Contributor

battaglr commented Oct 1, 2014

Maybe browser-upgrade to increase readability? Anyhow, making this site-agnostic is already a great idea.

@FagnerMartinsBrack
Copy link
Contributor

@battaglr That would not be consistent with how h5bp currently handles class names here

@arthurvr
Copy link
Member

arthurvr commented Oct 1, 2014

I'm fine with the browserupgrade classname. I personally think it's readable enough, and also, it's more consistent with classnames in h5bp.

@battaglr
Copy link
Contributor

battaglr commented Oct 1, 2014

@FagnerMartinsBrack: oops! You're right. :)

In that case browserupgrade sounds great. 👍

@alrra alrra closed this in d5e0625 Oct 6, 2014
@alilleybrinker alilleybrinker deleted the browser-upgrade-agnostic branch October 6, 2014 17:11
eleanor-byhook pushed a commit to eleanor-byhook/html5-boilerplate that referenced this pull request Feb 29, 2016
@alrra
Change the outdated browser prompt classname
ae83773 
While the outdated browser prompt currently links to `browsehappy.com`,
users are free and even encouraged to substitute the link with their own
page or site of preference.

This commit changes the `browsehappy` specific classname with the more
agnostic `browserupgrade` in order to make the link substitution
easier, but more importantly to hint to the users that they don't have
to stick with the currently default provided `browsehappy.com` link.

Ref: h5bp/html5-boilerplate#1582
     h5bp/html5-boilerplate#1608

Close h5bp/html5-boilerplate#1608
jeffreznik pushed a commit to jeffreznik/sw-test that referenced this pull request Oct 15, 2017
@alrra
Change the outdated browser prompt classname
ee109c2 
While the outdated browser prompt currently links to `browsehappy.com`,
users are free and even encouraged to substitute the link with their own
page or site of preference.

This commit changes the `browsehappy` specific classname with the more
agnostic `browserupgrade` in order to make the link substitution
easier, but more importantly to hint to the users that they don't have
to stick with the currently default provided `browsehappy.com` link.

Ref: h5bp#1582
     h5bp#1608

Close h5bp#1608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alilleybrinker @alrra @battaglr @FagnerMartinsBrack @arthurvr @drublic @frenzzy