Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config handling revert complex patch handling #90

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix config handling revert complex patch handling #90

wants to merge 4 commits into from

Commits on Sep 5, 2021

  1. Remove deprecated code

    @gytis-ivaskevicius
    gytis-ivaskevicius committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    bcd139d View commit details
    Browse the repository at this point in the history

  2. Remove repl path attribute since it is deprecated

    @gytis-ivaskevicius
    gytis-ivaskevicius committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    d883bfa View commit details
    Browse the repository at this point in the history

  3. Revert auto-channel detection that produced irrecoverable edge-cases 

    In more advanced usage scenarios, the guarantees of this code path
are never strong enough and the error produced is non-recoverable.

Sorry to lovers of "automagic".
    @blaggacao
    blaggacao committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    a4e267e View commit details
    Browse the repository at this point in the history

  4. Revert patching functionality and fix config handling 

    The patching functionality is fundamentally ill designed
and makes the code complex to the point that it is increasingly
hard to audit it for correctness.

The root of evil and ill-design is that it is a work-around for
what the Unoficial Flake Roadmap describes as follows:
- flake inputs are flake inputs
- patched flake inputs are flake inputs

Furthermore this commit fixes a naive implementation of nixpkgs.config
handling that causes nasty regressions on edge cases. Namely, not only
can a nixpkgs config be a function, but also the merging semantics
as defined by the module system requires detailed knowledge of the
potential shape of the cofig attrs / function.
    @blaggacao
    blaggacao committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    ed14e98 View commit details
    Browse the repository at this point in the history