Wasm features in Cargo.toml still used ?

[touilleMan]

Hi,

I've seen there is a wasm feature defined for crate zstd

zstd-rs/Cargo.toml

Line 38 in 2b63859

wasm = []

However there is no code using it, shouldn't it be removed ?
My guess is it's here in order not to break the compatibility, if that's the case it may be good to add a small comment explaining this feature doesn't do anything on purpose.

In any way I'd be happy to provide a PR about this ;-)

[crajcan]

I'm also curios as I'm trying to use this crate in a wasm build but I'm getting a runtime error.

[gyscos]

Hi, and thanks for the report!

Indeed, it seems to date back to 3 years ago when building for wasm needed a special feature to disable libc. Now it's indeed just a useless placeholder for backward compatibility. Though I guess that after 3 years it might be fine to remove? Or at the very least add a comment, you're absolutely right.

[touilleMan]

@gyscos do you want a PR removing the feature then ? 😃