You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The condition on line 821 in this snippet contains a typo, variable 'is_min' should not be enclosed in brackets because it creates a nested list. 'all()' built in function evaluates to True on nested non empty lists, therefore, this condition will always evaluate to True. The second, nested condition on line 822 hides this bug, and is unnecessary, because contents of variable 'is_min' are based on information about positions and chrom. ids of the two records that are being compared. https://github.com/gymreklab/TRTools/blob/eac7523a5eef740fe4eaa7aa9b51b3480eb59a60/trtools/compareSTR/compareSTR.py#L812-L831
Checks on previous lines ensure that is_min is always list of two bools.
The condition on line 821 in this snippet contains a typo, variable 'is_min' should not be enclosed in brackets because it creates a nested list. 'all()' built in function evaluates to True on nested non empty lists, therefore, this condition will always evaluate to True. The second, nested condition on line 822 hides this bug, and is unnecessary, because contents of variable 'is_min' are based on information about positions and chrom. ids of the two records that are being compared.
https://github.com/gymreklab/TRTools/blob/eac7523a5eef740fe4eaa7aa9b51b3480eb59a60/trtools/compareSTR/compareSTR.py#L812-L831
Checks on previous lines ensure that is_min is always list of two bools.
Fix:
This change doesn't break current tests
The text was updated successfully, but these errors were encountered: