-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft compile with compiler.stackMode=strip seems to break stack trace deobfuscation with sourcemaps #9956
Comments
Chrome does behave differently than htmlunit here, but still fails the test with draft+stackMode=strip. Chrome's failure:
Chrome's actual exception after deobf:
Chrome's exception after deobf when not using draft:
The expected line is
but going by counting stack frames, we instead get
which looks like nonsense (or confusion from merging too many functions due to strip mode). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LoggingRPCSuite was apparently written to support running in Chrome with stack mode strip, but still using the "modern" collector (renamed about three years after this commit):
gwt/user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml
Lines 25 to 40 in 469ef14
However, this wasn't run since at least ChromeCollector was renamed to ModernCollector (and possibly earlier, haven't confirmed), and running it in recent versions seems to break. When compiled without draft, HtmlUnit is able to send stack traces to the server and have them deobfuscated, so this is likely not a limitation of HtmlUnit vs some other browser.
The text was updated successfully, but these errors were encountered: