Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OMICRON_HTML in omicron.utils.get_omicron_version #174

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

duncanmmacleod
Copy link
Member

This PR patches omicron.utils.get_omicron_version() to always set OMICRON_HTML (to gettempdir()) to avoid a segfault.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #174 (25f4126) into master (62e4c52) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   35.12%   35.15%   +0.02%     
==========================================
  Files          30       30              
  Lines        2941     2942       +1     
==========================================
+ Hits         1033     1034       +1     
  Misses       1908     1908              
Flag Coverage Δ
Conda 35.15% <100.00%> (+0.02%) ⬆️
Linux 35.15% <100.00%> (+0.02%) ⬆️
macOS 35.15% <100.00%> (+0.02%) ⬆️
python3.10 35.15% <100.00%> (+0.02%) ⬆️
python3.11 35.15% <100.00%> (+0.02%) ⬆️
python3.9 35.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
omicron/utils.py 81.08% <100.00%> (+0.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@duncanmmacleod duncanmmacleod added this to the pyomicron 2.0.7 milestone Oct 27, 2023
@areeda
Copy link
Collaborator

areeda commented Oct 27, 2023

I don't understand why we have these flake8 problems.
If on my mac I do

git fetch upstream master
git switch upstream/master
git switch -c upstream_master
flake8

I get no complaints. My repositories are:

$ gre -v
origin	[email protected]:areeda/pyomicron.git (fetch)
origin	[email protected]:areeda/pyomicron.git (push)
upstream	[email protected]:gwpy/pyomicron.git (fetch)
upstream	[email protected]:gwpy/pyomicron.git (push)

Can you see what I'm missing?
..edit..
I also did a git clone of the repo and flake8 was silent. I have not quieted the whitespace around operators (for example)

@duncanmmacleod
Copy link
Member Author

The flake8 complaints are only visible using Python >=3.12, but are fixed by #175.

@areeda
Copy link
Collaborator

areeda commented Oct 28, 2023

Thanks

@areeda areeda merged commit 360a252 into gwpy:master Oct 28, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants