Skip to content

Commit

Permalink
omicron-process: don't pass X.509 to jobs
Browse files Browse the repository at this point in the history
it is not needed at all, but do pass request_memory
  • Loading branch information
duncanmmacleod committed Sep 19, 2023
1 parent 02eb897 commit 5030841
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions omicron/cli/process.py
Original file line number Diff line number Diff line change
Expand Up @@ -999,10 +999,12 @@ def main(args=None):
dag.set_dag_file(str(dagpath.with_suffix("")))

# set up condor commands for all jobs
condorcmds = {'accounting_group': args.condor_accounting_group,
'accounting_group_user': args.condor_accounting_group_user,
'request_disk': args.condor_request_disk,
'use_x509userproxy': 'True'}
condorcmds = {

Check warning on line 1002 in omicron/cli/process.py

View check run for this annotation

Codecov / codecov/patch

omicron/cli/process.py#L1002

Added line #L1002 was not covered by tests
"accounting_group": args.condor_accounting_group,
"accounting_group_user": args.condor_accounting_group_user,
"request_disk": args.condor_request_disk,
"request_memory": 1024, # MB
}
for cmd_ in args.condor_command:
key, value = cmd_.split('=', 1)
condorcmds[key.rstrip().lower()] = value.strip()
Expand All @@ -1013,8 +1015,9 @@ def main(args=None):
args.executable,
subdir=condir,
logdir=logdir,
**condorcmds
**condorcmds,
)

# This allows us to start with a memory request that works maybe 80%, but bumps it if we go over
# we also limit individual jobs to a max runtime to cause them to be vacates to deal with NFS hanging
reqmem = condorcmds.pop('request_memory', 1024)
Expand Down

0 comments on commit 5030841

Please sign in to comment.