-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace rstrip() with removesuffix() in triggers text #411
Conversation
@eagoetz this PR fixes the bug reported in: https://git.ligo.org/detchar/ligo-summary-pages/-/issues/246 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
==========================================
- Coverage 49.64% 49.27% -0.38%
==========================================
Files 60 60
Lines 8823 8789 -34
==========================================
- Hits 4380 4330 -50
- Misses 4443 4459 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eagoetz The failing tests are installing the version |
I think we may have to in the short term. Can you try restricting to |
…ould be changed once gwpy new release remove the deprecation.
Thank you, Evan! I also restricted the gwpy version to the latest. Once the new version is released we should change both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR replaces
rstrip('.0')
withremovesuffix('.00')
to avoid removing any0
before.
in the string. See the examples below: