Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fir_zero_filter rolls data too far by -1 #4858

Open
matijsv opened this issue Aug 23, 2024 · 1 comment
Open

fir_zero_filter rolls data too far by -1 #4858

matijsv opened this issue Aug 23, 2024 · 1 comment

Comments

@matijsv
Copy link

matijsv commented Aug 23, 2024 •
edited
Loading

The function is supposed to correct the phase shift caused by using the filter, but it over-rolls by -1 datapoint. Easily fixed by calling .roll(1) after, on the affected timeseries
@matijsv matijsv changed the title fir_zero_filter rolls data to0 far by 1 fir_zero_filter rolls data to0 far by -1 Aug 23, 2024
@matijsv matijsv changed the title fir_zero_filter rolls data to0 far by -1 fir_zero_filter rolls data too far by -1 Aug 23, 2024
@ahnitz
Copy link
Member

ahnitz commented Aug 26, 2024

@matijsv Can you provide a minimal example? Also are you willing to submit a PR to address the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahnitz @matijsv