Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noexcept #56

Open
bftjoe opened this issue Jun 6, 2024 · 2 comments
Open

noexcept #56

bftjoe opened this issue Jun 6, 2024 · 2 comments

Comments

@bftjoe
Copy link
Contributor

bftjoe commented Jun 6, 2024

Please make an option to make this not throw exceptions. Throwing exceptions forces changes to the code or to enable exceptions which can impact performance.

@gvinciguerra
Copy link
Owner

Hi, can you describe a bit what you need this for, what exceptions are you referring to (e.g. the ones thrown during construction by the PGMIndex class?), and what alternatives to exceptions you were thinking of?

@bftjoe
Copy link
Contributor Author

bftjoe commented Jun 11, 2024

For instance, try to compile this example with -fno-exceptions

https://github.com/gvinciguerra/PGM-index/blob/master/examples/updates.cpp

This library lets you compile it with no exceptions:
https://github.com/search?q=repo%3Ayhirose%2Fcpp-httplib%20httplib_no_exceptions&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants