Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures with Oracle 23.3 image #22

Closed
cpcloud opened this issue Sep 25, 2023 · 7 comments
Closed

Failures with Oracle 23.3 image #22

cpcloud opened this issue Sep 25, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@cpcloud
Copy link

cpcloud commented Sep 25, 2023

Hi 👋🏻!

We've been using the docker images produced from this repo without issue for quite a while over in https://github.com/ibis-project/ibis.

They've been working quite well!

Recently we're seeing some errors that are difficult to understand: https://github.com/ibis-project/ibis/actions/runs/6296921012/job/17092938287

We're not (yet) pinning the version of the image, so we picked up 23.3 in a CI run. To ensure our CI isn't flaky, for now we're going to pin our image to 23.2.

The queries that seem to be causing the errors are queries like:

DROP TABLE IF EXISTS "diamonds";

The error messages all look similar to this one:

ERROR ibis/backends/tests/test_client.py::test_load_data_sqlalchemy[oracle-pyarrow table] - sqlalchemy.exc.DatabaseError: (oracledb.exceptions.DatabaseError) ORA-04088: error during execution of trigger 'SYS.DELETE_ENTRIES'

One thing that might be gumming things up is that we're running the test suite in parallel. Is that supported with Oracle? Should we be able to run multiple processes that are reading from and writing to the database in parallel? That said, I was able to reproduce the issue by running a single test with no parallelism involved. We're actually running the Oracle tests serially.

Thanks!

@gvenzl
Copy link
Owner

gvenzl commented Sep 26, 2023

Thanks a lot for reporting this, @cpcloud!
I will take a look ASAP!

Sorry for the disruption!

@gvenzl
Copy link
Owner

gvenzl commented Sep 26, 2023

The error shows the same symptoms as #23:

[SQL: 
DROP TABLE "_ibis_alchemy_table_gevbestjv5fj7arkgpvmpmmc7q"]
(Background on this error at: https://sqlalche.me/e/14/4xp6)
ERROR ibis/backends/tests/test_client.py::test_load_data_sqlalchemy[oracle-dataframe] - sqlalchemy.exc.DatabaseError: (oracledb.exceptions.DatabaseError) ORA-04088: error during execution of trigger 'SYS.DELETE_ENTRIES'
ORA-00604: Error occurred at recursive SQL level 1. Check subsequent errors.
ORA-01804: failure to initialize timezone information
Help: https://docs.oracle.com/error-help/db/ora-04088/
[SQL: 
DROP TABLE "_ibis_alchemy_table_7trzdmne3vcgradzt2xj6az4z4"]
(Background on this error at: https://sqlalche.me/e/14/4xp6)
ERROR ibis/backends/tests/test_client.py::test_insert_overwrite_from_expr[oracle] - sqlalchemy.exc.DatabaseError: (oracledb.exceptions.DatabaseError) ORA-04088: error during execution of trigger 'SYS.DELETE_ENTRIES'
ORA-00604: Error occurred at recursive SQL level 1. Check subsequent errors.
ORA-01804: failure to initialize timezone information

@cpcloud, I think I have isolated and fixed the issue.
Would it be possible to rerun these tests and confirm, please?

@cpcloud
Copy link
Author

cpcloud commented Sep 26, 2023

Thanks @gvenzl!

Tests are running here: ibis-project/ibis#7216

@cpcloud
Copy link
Author

cpcloud commented Sep 26, 2023

Looks like the issue is fixed! Thanks @gvenzl!

@cpcloud cpcloud closed this as completed Sep 26, 2023
@gvenzl
Copy link
Owner

gvenzl commented Sep 26, 2023

Great, thanks a lot @cpcloud and sorry for the disruption!

@cpcloud
Copy link
Author

cpcloud commented Sep 26, 2023

No need to apologize, we're happy to have a free docker image that we don't maintain to test Oracle with!

@gvenzl
Copy link
Owner

gvenzl commented Sep 27, 2023

It's my pleasure, if you ever need anything or have questions, happy to help anywhere I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants