-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] suppress part naming in volumes for use with Kavita #44
Comments
Thank you for your feedback. Something to that effect will be implemented as part of #29 (either as custom name templates or flags to specify how the default name gets transformed). So it will be a bit more general than what you want (I think the folder name you implemented already could fit in that as well). Not sure when it will be done though, so if you already have a PR, you can send it and I will include it. For the option name, set it to what you want and I will change it if needed. |
additional part naming comes from core.py line 234 for when the first part of a new volume is created. todo: add way manipulate this or edit it post assignment. |
Sorry, I had not seen your question. The Anyway, I got around to implement a feature that should answer your request. It allows the renaming of the output EPUB title, its filename or its folder name (using the |
no worries, I figured that it was coming from the API but since the output was predictable I put in a very dirty hack to solve my issue. |
In addition to #39 in order to get full compatibility with Kavita the part naming of volumes needs to be suppressed
as generating volumes with different file name but the same metadata will only allow the first volume generated to be accessed without manual file wrangling.
Kavita when executing a library refresh is able to recognise that there is additional content (parts) in an existing file and will update the volume to show that there is additional unread segments and update your bookmark to load the new part.
I am not sure of the best place in which to do this.
in my local testing I have updated line 271 of core.py as follows
title = f"{title_base}"
fromtitle = f"{title_base} [{part_segment}]"
this results in epubs with only the volume in the name
"Hell_Mode_Volume_7_parts_1_to_4.epub"
vs"Hell_Mode_Volume_7.epub"
I am happy to create a PR with a switch that does this.
I would appreciate some discussion on this one around suggested option name and what your willingness to include this might be.
Thanks, AnAngryBrit
The text was updated successfully, but these errors were encountered: