Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for making TOC by chapter not part #37

Open
sh1mmer opened this issue Oct 5, 2023 · 2 comments
Open

[Feature Request] Add support for making TOC by chapter not part #37

sh1mmer opened this issue Oct 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@sh1mmer
Copy link

sh1mmer commented Oct 5, 2023

It would be nice if when making ebooks by volume the chapter heading could be used instead of the parts. I looked at the contents of a bunch of different series I read and all the ones I looked at used <h1> to indicate chapter headings pretty cleanly.

I don't think it would be too complex. Since title is set core._process_single_epub_content() [1] I was thinking you could re-process contents [2] to be split by <h1> instead of part and just change the part titles.

I'll try and make a PR that we can discuss.

@gvellut
Copy link
Owner

gvellut commented Oct 7, 2023

Thank you for your feedback.

OK. It is fine as an option.

I will be waiting for your PR. Would that be only for full volumes ? (I don't think parts always start with a h1 title, so it might be confusing).

@gvellut gvellut added the enhancement New feature or request label Oct 7, 2023
@sh1mmer
Copy link
Author

sh1mmer commented Oct 12, 2023

I think it should work for non full volumes with the caveat you might not have a complete chapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants