Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to run with --parts n: #21

Closed
shakyr opened this issue Jul 1, 2022 · 1 comment
Closed

Fails to run with --parts n: #21

shakyr opened this issue Jul 1, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@shakyr
Copy link

shakyr commented Jul 1, 2022

For version 36, currently unable to run the command with --parts n: as per the example below.

jncep epub --output ./books --parts 1: --byvolume --images https://j-novel.club/series/the-great-cleric

*** An unrecoverable error occured ***
'>=' not supported between instances of 'int' and 'str'

@gvellut gvellut added the bug Something isn't working label Jul 1, 2022
@gvellut gvellut closed this as completed in e34f013 Jul 1, 2022
@gvellut
Copy link
Owner

gvellut commented Jul 1, 2022

Thank you for your feedback.

There was indeed a bug. I corrected it and added some unit tests so hopefully every case is covered.

I will make a new release soon (but I want to add an additional feature so it may be a few days) so in the meantime you can use :

  • 1.1:
  • or just :
  • or even no --parts (since you use the series URL)

instead of 1: if you want to make it work (I assume you want the whole series).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants