-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cover.jpg not included in epub file #20
Comments
By updating, you mean to version 35 from version 34? There shouldn't be any change to the downloading of the cover. I have tested with The name "cover.jpg" file for the EPUB cover is only present when no cover can be found (and shouldn't correspond to any actual file in that case). Do the EPUB files with the issue with covers you mention (ie cover is included in the EPUB but you need to rename it) include the first part of the volume? Also, what do you mean by "showing the correct image for their thumbnails" ? If you open the EPUB in an EPUB reader, isn't the cover shown? Or are you actually talking about something else? If you are talking about the cover when you open the EPUB in a reader: Can you tell me:
Thank you. |
Ah, I'm talking about the thumbnails in File Explorer which are basically whatever the first alphabetical image in the EPUB is. No, not v34 to v35; I'm not sure what version I was running prior, only that it was not using the new version of the API as in issue #14 . Prior to the API change here is an example complete volume: ...which has a cover.jpg, and displays... ...as the preview and thumbnail. I have checked a random sample of volumes and all have a cover.jpg in them. Using v35: ...you can see there is no cover.jpg, meaning it displays... ...as the preview/thumbnail. Opening it in an EPUB reader is fine, as they are smart and looking for specific information to find the cover; File Explorer is dumb :-) It's not a huge deal if I just have to manually add a cover file, just curious as to what would have changed. If it is possible to force it to make a cover.jpg I certainly wouldn't complain ;-) As always thank you for a super-useful tool! |
Here's the output of something with no cover.jpg:
|
OK I understand now. I will see what I can do to add the option to force the name or just make sure the cover is always the first in alphabetical order by default. |
I have made a new release (v36). The cover image is now named |
Since updating, downloaded epubs are not showing the correct image for their thumbnails.
I checked by opening the .epub in 7-Zip and noticed there is no "cover.jpg" file in the archive, which was present in previous files and was just a copy of whichever image was identified as the cover. I can fix individual files by extracting the cover image, renaming it to "cover.jpg" and adding it to the .epub archive.
On some files it's not an issue, but this is because the cover image happens to be the first in the file alphabetically.
The text was updated successfully, but these errors were encountered: