Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawing element must be below rowBreaks according to spec or corrupt worksheet #590

Merged
merged 4 commits into from
Sep 5, 2018

Conversation

nevace
Copy link
Contributor

@nevace nevace commented Jun 20, 2018

I had an issue with adding both images and a pagebreak to a worksheet. Adding them independently was fine but adding them both together result in a corrupt document.

The issue was related to the ordering of the elements. drawing must be below rowBreaks as seen here:

https://stackoverflow.com/a/12221477/4564456

You can also see the ordering of all the other elements there in case this comes up with new features. Moving drawing and picture below rowBreaks fixes the issue.

I'm currently blocked until this is merged so please let me know if there's anything else I can do to help! :)

Thanks

@nevace
Copy link
Contributor Author

nevace commented Jul 12, 2018

@guyonroche I appreciate you're busy but do you have an ETA for the next release? I'm currently blocked by this issue.

Thanks

@guyonroche guyonroche merged commit 00a34d7 into exceljs:master Sep 5, 2018
@guyonroche
Copy link
Collaborator

Appologies for the delay - will test and publish today

shuntagami added a commit to shuntagami/exceljs that referenced this pull request Dec 11, 2023
This was referenced Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants