Add support for inlineStr, including rich text #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2018 11:52
- When streaming, render "richText" values as <c t="inlineStr"><is><r>...</r></is></c> - Parse inlineStr values correctly, including plain text and rich text
guyonroche
requested changes
Mar 13, 2018
lib/xlsx/xform/sheet/cell-xform.js
Outdated
| return true; | ||
|
|
||
| case 'r': | ||
| this.parser = richTextXForm;//this.map.r; |
There was a problem hiding this comment.
parsing is state-full so this will cause problems if more than one parse is running.
There was a problem hiding this comment.
Good point! See fix below...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #409 and hopefully also covers the case in #495.