Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some comments in readme according csv importing #396

Merged
merged 1 commit into from
Oct 7, 2017

Conversation

Imperat
Copy link
Contributor

@Imperat Imperat commented Sep 8, 2017

Add some docs about importing scv to the stream.

Add some docs about importing scv
@@ -1255,7 +1255,9 @@ workbook.csv.writeFile(filename)
});

// write to a stream
workbook.csv.write(stream)
// Be careful that you need to provide sheetName or
// sheetId for correct import to scv.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not scv. It's named .csv

@guyonroche guyonroche merged commit 8cf7183 into exceljs:master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants