Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for identifier #259

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Add support for identifier #259

merged 1 commit into from
Feb 16, 2017

Conversation

holm
Copy link
Contributor

@holm holm commented Jan 31, 2017

I ran into a similar issue to #176, just for dc:identifier. I found the property in the spec, so I added it in this PR. Unfortunately I haven't been able to receive the file from the customer that ran into this (I only have the stacktrace), but I am trying to get it so I can create a test case.

@guyonroche guyonroche merged commit 56fed15 into exceljs:master Feb 16, 2017
@guyonroche
Copy link
Collaborator

Cool - thanks.
If you do manage to get the file and write a test-case, please do add another PR for it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants