Incorrect resolving for scoped import maps

[costingeana]

Hello, @guybedford,
The last es-module-shims version fails to identify the scoped import maps.

This is a piece of the import map that I use (generated with jspm):

{
  "imports": {
    "@hubgets/heros.uil.loader": "./jspm_packages/npm/@hubgets/[email protected]/lib/index.js",
    "@hubgets/heros.uil.loader/": "./jspm_packages/npm/@hubgets/[email protected]/"
},
 "scopes": {
    "jspm_packages/npm/@hubgets/[email protected]/": {
      "@hubgets/heros.datalocal": "../[email protected]/lib/index.js",
      "@hubgets/heros.datalocal/": "../[email protected]/",
      "@hubgets/lib.error": "../[email protected]/lib/index.js",
      "@hubgets/lib.error/": "../[email protected]/",
      "@hubgets/lib.useragent": "../[email protected]/lib/index.js",
      "@hubgets/lib.useragent/": "../[email protected]/"
    }
}

I investigated a little bit and I think the problem's root is in parseImportMap:

es-module-shims/src/common.js

Line 144 in c2ad855

scopes[resolvedScopeName] = resolvePackages(scope, baseUrl) || {};

I think this line should be:

scopes[resolvedScopeName] = resolvePackages(scope, resolvedScopeName) || {};

baseUrl for scoped packages should be the resolved url of their 'parent'.

Please let me know if you think I identified correctly the cause of the issue and I'll come up with a pull request.

Thanks!

[guybedford]

This is actually working as designed, and is a bug in jspm itself rather (and SystemJS, with the PR for SystemJS currently at systemjs/systemjs#1975).

The import maps specification changed such that scopes are resolved relative to the import map base, instead of the scope itself.

[costingeana]

Thanks for your answer. Is there any issue added in jspm related to this matter?

[guybedford]

See jspm/jspm-cli#2493.

[costingeana]

Thanks!

[guybedford]

Sure, this fix is now released in 2.0.0-beta.7. That should resolve this, but please let me know if you have further issues at all.

[costingeana]

I just tested it and it works. Thanks once again!