fix: prefer the later version of firefox's db #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current scenario if you did update your FF then the old db is used because it still exists (FF doesn't clean it up). This fixes that by instead preferring the new db if it exists.
|
I still have had very little success with Firefox and this method. I wish they would just use the certutil |
|
@jimthedev thanks for the PR! Can you clarify what you mean by having little success with this method? I'm running on Windows so have to go through the manual verification steps for this which works fine. If there are issues on Mac, perhaps we should just switch to running that manual prompt on Mac as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current scenario if you did update your FF then the old db is used because it still exists (FF doesn't clean it up).
This fixes that by instead preferring the new db if it exists.