You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The python binding code has a couple of error handling issues:
fails to process error when it does return JSON. In all cases it returns a string which is often of a python dict from json and not just the error msg
try blocks are catching exceptions they should not. For example KeyboardInterrupt which can be an issue if user tried to stop code at the unlucky time.
Additionally it would be great if this repo could be used in existing python based git repo as a submodule but the path names make it impossible to import as a git submodule.
I can provide a pull request if it will be desired. Just not sure from some of the response times for other pull requests.
The text was updated successfully, but these errors were encountered:
The python binding code has a couple of error handling issues:
fails to process error when it does return JSON. In all cases it returns a string which is often of a python dict from json and not just the error msg
try blocks are catching exceptions they should not. For example KeyboardInterrupt which can be an issue if user tried to stop code at the unlucky time.
Additionally it would be great if this repo could be used in existing python based git repo as a submodule but the path names make it impossible to import as a git submodule.
I can provide a pull request if it will be desired. Just not sure from some of the response times for other pull requests.
The text was updated successfully, but these errors were encountered: