Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python bindings has error handing issues and path name issues. #26

Open
pceBuildMaster opened this issue Feb 19, 2020 · 1 comment
Open

Comments

@pceBuildMaster
Copy link

The python binding code has a couple of error handling issues:

  • fails to process error when it does return JSON. In all cases it returns a string which is often of a python dict from json and not just the error msg

  • try blocks are catching exceptions they should not. For example KeyboardInterrupt which can be an issue if user tried to stop code at the unlucky time.

Additionally it would be great if this repo could be used in existing python based git repo as a submodule but the path names make it impossible to import as a git submodule.

I can provide a pull request if it will be desired. Just not sure from some of the response times for other pull requests.

@jonridera
Copy link
Contributor

Hi @pceBuildMaster ,

Thanks for reaching out. I would be glad to review a pull request to help improve the bindings based on the issues you described.

The repository was not regularly monitored in the past, however our team should be notified of any new pull requests going forward.

Regards,
Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants