fixes #50 #51
Closed
fixes #50 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The [stream](https://nodejs.org/api/stream.html#stream_stream) or [buffer](https://nodejs.org/api/buffer.html#buffer_class_buffer) of the file. For example: | ||
| ```js | ||
| if (file.isBuffer()) { | ||
| var contents = file.contents.toString('utf8') |
There was a problem hiding this comment.
@contra no it isn't and it's actually correct as per node styleguide
There was a problem hiding this comment.
@phated guess i got brainwashed by crockford
There was a problem hiding this comment.
lol i was actually thinking about this while writing the example but then i was like mehhhh adding a var declaration above seemed like too much...
There was a problem hiding this comment.
The .toString argument is also moot as it's the default.
|
This is fixed on the master |
|
@stevemao guess GH doesn't close multiple issues per commit msg |
|
No, https://help.github.com/articles/closing-issues-via-commit-messages/ |
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.