Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove normalization of file paths into globs #346

Open
phated opened this issue Jun 25, 2023 · 0 comments
Open

Remove normalization of file paths into globs #346

phated opened this issue Jun 25, 2023 · 0 comments

Comments

@phated
Copy link
Member

phated commented Jun 25, 2023

Everything below vinyl-fs expects globs to use / instead of \\ (since \\ is for escaping). However, I believe both the latest major versions of vinyl-fs and glob-watcher accept \\ in globs.

We should ensure both projects only accept / for globs. This also requires separating globs from file paths in our test constants.
@phated phated added this to post-v5 Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
post-v5
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phated