Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplication of symlink logic between symlink and dest methods #250

Closed
phated opened this issue Jun 23, 2017 · 1 comment
Closed

Deduplication of symlink logic between symlink and dest methods #250

phated opened this issue Jun 23, 2017 · 1 comment

Comments

@phated
Copy link
Member

phated commented Jun 23, 2017

As per @erikkemperman's comments in #246, there's a bunch of duplication between the 2 methods. We should look into reducing that code.

@phated
Copy link
Member Author

phated commented Nov 10, 2017

As of #254, these have diverged quite a bit and don't make sense to merge again.

@phated phated closed this as completed Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant