aria-describedby not set when using data-parsley-error-message

[leejacobson]

What kind of issue is this? (put 'x' between the square brackets)

• Question. This issue tracker is not the place for questions. If you want to ask how to do
  something, or to understand why something isn't working the way you expect it to, use
  http://stackoverflow.com/questions/ask .
  Provide working code, starting from http://codepen.io/marcandre/pen/jqbzyN?editors=101.
  We monitor the tag parsley.js.

• Bug report. If you’ve found a bug, you must provide a minimal example in a CodePen,
  starting from http://codepen.io/marcandre/pen/jqbzyN?editors=101 .

• Feature Request. Make sure there's no good way to do what you want first;
  consider asking on http://stackoverflow.com/questions/ask first.

Example: http://jsfiddle.net/bn59odcu/

If you submit the form in the example above with two invalid email addresses the first input field will not have an aria-describedby attribute to reference the error message, but the second input will.

The issue seems to be related to using data-parsley-error-message specifically. Where we have used this attribute it is causing an accessibly issue on the project I'm working on and I assume it could be causing similar issues on other sites using Parsley. I can switch out the references to data-parsley-error-message for their error-specific alternatives for now, but it would be nice to have an official fix for this going forward.

[leejacobson]

Additionally, if an input already has an aria-describedby attribute set, Parsley should append to it instead of replacing it.

As per the docs, the aria-describedby attribute supports multiple space separated IDs,
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-describedby_attribute

[marcandre]

First of, thank you for the fiddle. It's much appreciated! Second, sorry for the issue you are having.

It's a curious thing. It may have to do with calling _updateError instead of _addError? I'm not sure if, or why at this point. I'm also not sure when I'll be able to have a look at it myself, but of course a PR/sponsorship is always welcome.

I also agree about the issue of appending; the two are not related though.

[WW3]

Also,

• remove the attribute when the field gets a valid value
• when .parsley-custom-error-message messages are visually hidden, consider also hiding from screen reader users by toggling an aria-hidden attribute

[stevenMouret]

Fixed in my PR.

[marcandre]

Should be addressed correctly in 2.9.2.

Thanks for the inputs and your patience!