Fixes #2601 - Adds ability to filter TreeView branches/leaves #2599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2601 - Adds ability to filter TreeView branches/leaves (e.g. free text search).
I've created this targeting
develop
as it has quite a small footprint and its a really nice to have core feature I think.It should be pretty easy to cherry pick to
v2_develop
Because a tree is hierarchical its important to consider whether a filter matches the parent or child too. I went for greatest matching so:
As with all things in
TableView
it is only the expanded nodes that get processed. If a node is not expanded its children are unknown (so not considered for matching). This is because of how the table builds itself as the user expands rather than loading everything up front (which can be impossible for some data structures - e.g. file system).Draft as now so I can write some tests
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)