Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2465 - Simplify/Enforce LayoutStyle.Absolute when X, Y, Width, and/or Height are null or Absolute() #2467

Merged
merged 20 commits into from
Jan 4, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Mar 30, 2023

Fixes #2465

Terminal.Gui/Core/View.cs Outdated Show resolved Hide resolved
Terminal.Gui/Core/View.cs Outdated Show resolved Hide resolved
@tig tig force-pushed the v2_fixes_2465_simplify_layoutstyle branch from c755979 to 4da20ac Compare January 3, 2024 18:54
@tig tig marked this pull request as ready for review January 3, 2024 20:08
@tig
Copy link
Collaborator Author

tig commented Jan 3, 2024

@BDisp and @tznind - I've finally come back to this PR and:

  • Merged with v2_develop
  • Updated API docs to be more complete and accurate
  • Fixed all Views that were using Bounds or calling LayoutSubViews before IsInitalized
  • Fixed a few other things (esp in ComboBox) that needed fixing

What I didn't do:

  • Actually enforce LayoutStyle as was originally proposed here. I'd love your thoughts on that now.

Please review asap. Thanks!

@tig tig requested a review from tznind January 3, 2024 20:11
@BDisp
Copy link
Collaborator

BDisp commented Jan 3, 2024

Something is wrong with All Views Tester. It starting at (0,0) but navigate down and then up the views don't start at (0,0).

@tig
Copy link
Collaborator Author

tig commented Jan 3, 2024

Something is wrong with All Views Tester. It starting at (0,0) but navigate down and then up the views don't start at (0,0).

Ah, with mouse. With keyboard it's fine. On it...

@BDisp
Copy link
Collaborator

BDisp commented Jan 3, 2024

Something is wrong with All Views Tester. It starting at (0,0) but navigate down and then up the views don't start at (0,0).

Ah, with mouse. With keyboard it's fine. On it...

With the keyboard. Navigate downward until Dialog and then navigate upward and you will see that the views aren't at (0,0) anymore.

Edit:
Dialog is centered horizontal and vertical and thus it seems the upper left coordinate is changed for all views.

@tig
Copy link
Collaborator Author

tig commented Jan 3, 2024

Something is wrong with All Views Tester. It starting at (0,0) but navigate down and then up the views don't start at (0,0).

Ah, with mouse. With keyboard it's fine. On it...

With the keyboard. Navigate downward until Dialog and then navigate upward and you will see that the views aren't at (0,0) anymore.

Edit: Dialog is centered horizontal and vertical and thus it seems the upper left coordinate is changed for all views.

Fixed.

@BDisp
Copy link
Collaborator

BDisp commented Jan 3, 2024

Some of the views aren't show, like the TextField.

@tig
Copy link
Collaborator Author

tig commented Jan 3, 2024

Some of the views aren't show, like the TextField.

Fixed. ;-)

@tig
Copy link
Collaborator Author

tig commented Jan 4, 2024

@BDisp I'd like to merge this so it can be picked up in #3078 and BDisp#172 so I can more easily debug (this PR removes a ton of debug spew).

Are you good with my changes here?

@BDisp
Copy link
Collaborator

BDisp commented Jan 4, 2024

Done @tig. Thanks.

@tig tig merged commit bc41d9b into gui-cs:v2_develop Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants