Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 View cleanup #2428

Merged
merged 3 commits into from
Mar 18, 2023
Merged

V2 View cleanup #2428

merged 3 commits into from
Mar 18, 2023

Conversation

tig
Copy link
Collaborator

@tig tig commented Mar 18, 2023

As I progress on the v2 View redesign (#2360), I'm finding things in the View hierarchy that are hard to understand, overly complex, poorly named, overly exposed (publicly), and oddly tested.

Instead of fixing this in one massive PR that includes a massive redesign/rearchitecture, I'm going to be doing PRs like this one that fix them without significantly changing functionality.

This PR:

  • Simplifies, clarifies, and better documents View initialization.
  • Renames internal methods and property names to increase code clarity
  • Hides (internal) and removes some formerly public members that are unlikely to be used - a lot having to do with sizing

@tig tig requested a review from migueldeicaza as a code owner March 18, 2023 15:22
@tig tig merged commit 8bd9ac7 into gui-cs:v2_develop Mar 18, 2023
@tig tig deleted the v2_view_cleanup branch April 3, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant