Fixes #2360 - v2 View re-architecture..

[tig]

See: #2360

In this PR I have proven:

• It is possible to refactor View to have a "real" Bounds where the Location part can be non-zero
• A real "margin", "border", and "padding" thickness can be implemented that matches how these concepts work in HTML
• The border can be drawn using LineCanvas
• Borders can "autojoin" using LineCanvas such that SplitContainer is completely unnecessary.
• 20/30% of the existing View, Toplevel, Window, and FrameView can be removed from the project.
• It will be a massive breaking change, but porting apps to use the new architecture will be relatively easy, and will result in less code in apps.

See the latest v2 View Spec here:

https://github.com/tig/Terminal.Gui/blob/v2_view2_experiment/docfx/v2specs/View.md

Here's the latest GIF:

[tig]

I just integrated my View2 experiment into View directly.

While a bunch of stuff is broken (including a lot of unit tests), I'm now pretty confident this will all work and be worth it (I removed hundreds and hundreds of very complex lines of code from the project. Window and FrameView are now extremely simple etc...).

The old Border class still exists but is just there as a sort of compatibility layer for existing code; it doesn't actually do anything.

Fun stuff...

[BDisp]

I just integrated my View2 experiment into View directly.

Good choice.

While a bunch of stuff is broken (including a lot of unit tests), I'm now pretty confident this will all work and be worth it (I removed hundreds and hundreds of very complex lines of code from the project. Window and FrameView are now extremely simple etc...).

Well the unit tests may work differently but most of them must demonstrate more or less the identical result, with some adjustments.

The old Border class still exists but is just there as a sort of compatibility layer for existing code; it doesn't actually do anything.

I think this will confusing the users. The v2 is a breaking change version with more features, so we don't have to worry with backwards compatible. The border in the View class is working right as it should. If you want to help the users to use the new border concept maybe you can wrap all the properties, methods, etc. (Margin, BorderFrame, Padding, Thickness) in the Border.cs, because normally is where the users will search for border.

[BDisp]

@tig I played around the Borders scenarios and I changing the border style, border thickness, padding thickness, border brush, background color, effect 3D, well all of them and nothing changing. It's supposed to be like this?

[tig]

@tig I played around the Borders scenarios and I changing the border style, border thickness, padding thickness, border brush, background color, effect 3D, well all of them and nothing changing. It's supposed to be like this?

Yes because this is still just a proof of concept and not finished.

[tig]

If you have an urge to update one of the border scenarios to use the new architecture that would be appreciated.

More than likely you'll find stuff I'm doing that doesn't make sense. 😏

[tig]

If you have an urge to update one of the border scenarios to use the new architecture that would be appreciated.

More than likely you'll find stuff I'm doing that doesn't make sense. 😏

Make sure you read the spec (in docfx/articles/View.md)..

Its MOSTLY accurate relative to my vision . It contains some VERY CLEAR ERRORs and questions, but directionally paints the the vision.

[BDisp]

@tig this was done on the Border class.

[tig]

@tig this was done on the Border class.

Woot!

How did the port go?

It now needs UI to control View.Margin as well.

I'm confused about something tho: I thought I disabled the 3d effects in my prototype, but I see it working in the image you posted.

[BDisp]

This is only the Border without your API. It also has a margin which normally show the superview background color. The 3D effect will be draw on the margin.

[tig]

Woot!

This is ready, finally.

Search for "BUGBUG: v2" and you'll find places in both the core code where I hacked around something or disabled a unit test.

Just about everything works.

What's not done yet in the re-architecture is:

• Refactor Redraw - Non-virtual with the right set of virtual OnXXX methods #2482
• Reorganize file structure (& namespace) #2469
• Simplify/Enforce LayoutStyle.Absolute when X, Y, Width, and/or Height are null or Absolute() #2465
• ScrollBarView etc... needs redesign to utilize new View architecture #2464
• GraphView needs to be refactored to use new View Frames #2463
• A view referencing a View that's not a peer (same superview) in Dim/Pos should not be allowed #2461
• A view referencing a View that's not a peer (same superview) in Dim/Pos should not be allowed #2461
• Unit tests that test location/size before BeginInit() and/or LayoutSubviews() are bogus #2449
• Finish Dim.Auto - DimAutoStyle.Content is half-baked #2432 - Get rid of Autosize
• Remove need for TileView - Use LineCanvas to draw borders and auto-join borders #2483
• Move all rendering out of Toplevel, FrameView, Window, etc... into View. #2484
• Refactor Wizard to use View v2 #2485
• Remove the old Border class and add a simple way of turning on/off a border #2486
• Add ability for Frame to host subviews (adornments) #2487
• Refactor MenuBar and StatusBar to be adornments #2488
• Create new ScrollBar based on a new Scroll and remove ScrollBarView/ScrollView #2489
• Remove Toplevel - #2490
• Get rid of Toplevel - Introduce Runnable and Overlapped instead #2491