Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Button alignment in MessageBox is no longer centered #3523

Closed
fergusonr opened this issue Jun 1, 2024 · 3 comments · Fixed by #3639
Closed

v2: Button alignment in MessageBox is no longer centered #3523

fergusonr opened this issue Jun 1, 2024 · 3 comments · Fixed by #3639
Assignees
Labels
Milestone

Comments

@fergusonr
Copy link
Contributor

2.0.0-pre.1491 MessageBox buttons are aligned to the right. They were previously centred.

If this is a v2 style change, then perhaps we should have a Query() method signature with a ButtonAlignment parameter

MessageBox.Query(50, 7, "Quit?", "Are you sure you want to quit?", 0, "Yes", "No");

MessageBox

@tig
Copy link
Collaborator

tig commented Jun 1, 2024

With POS.Align I was experimenting with layouts. I forgot I left this in.

For v2 I want to do two things:

Change the defaults from v1 to make the look and feel distinct.

Make it configurable (MB and Dialog can/should be different).

@tig
Copy link
Collaborator

tig commented Jun 1, 2024

And I mean configurable via CM. Not api.

@fergusonr
Copy link
Contributor Author

And I mean configurable via CM. Not api.

Great thanks.

@tig tig added the bug label Jun 9, 2024
@tig tig added this to the V2 Beta milestone Jun 9, 2024
@tig tig self-assigned this Jul 11, 2024
@tig tig moved this to 🏗 Approved - In progress in Terminal.Gui V2 Initial Release Jul 11, 2024
@tig tig closed this as completed in #3639 Aug 4, 2024
@tig tig closed this as completed in 990b7ee Aug 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗 Approved - In progress to ✅ Done in Terminal.Gui V2 Initial Release Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants