Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Unit Test GitHub Action back to ubuntu-latest #3052

Closed
tig opened this issue Dec 16, 2023 · 1 comment
Closed

Move Unit Test GitHub Action back to ubuntu-latest #3052

tig opened this issue Dec 16, 2023 · 1 comment
Assignees
@tig
Labels
bug github_actions Pull requests that update GitHub Actions code testing Issues related to testing
Milestone
V2 Alpha

Comments

@tig
Copy link
Collaborator

tig commented Dec 16, 2023 •
edited
Loading

In #2927:

Based on this, I moved running the test to windows-latest instead of ubuntu-latest. Tests now pass.
microsoft/vstest#2952
Sheesh.

My opinion is that when that vstest issue is fixed then change it again to ubuntu-latest again because normally Windows users forgot to test in WSL first to detect conflicts before pushing them. Don't you think?

I agree. FWIW, the tests DO sometimes fail for me now under WSL:
image

So, this might just be a bad test on our part.

Originally posted by @tig in #2927 (comment)

Related: #1316

Once #2927 is merged, and we can diagnose why the tests are failing under Linux, we should change back.
@tig tig added testing Issues related to testing github_actions Pull requests that update GitHub Actions code bug labels Dec 16, 2023
@tig tig moved this to 📋 Approved - Need Owner in Terminal.Gui V2 Alpha May 20, 2024
@tig tig moved this from 📋 Approved - Need Owner to 🏗 Approved - In progress in Terminal.Gui V2 Alpha May 20, 2024
@tig tig self-assigned this May 20, 2024
@tig tig added this to the V2 Alpha milestone May 25, 2024
This was referenced Jul 7, 2024
Merged
Closed
Merged
Merged
@tig
Copy link
Collaborator Author

tig commented Jul 7, 2024

I just spent 3+ hours trying to figure this out.

No joy.

FWIW, it fails on macos-latest as well.

@tig tig closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tig tig

Labels
bug github_actions Pull requests that update GitHub Actions code testing Issues related to testing
Projects
Terminal.Gui V2 Initial Release
Status: ✅ Done
Terminal.Gui V2 Alpha
Status: 🏗 Approved - In progress
Terminal.Gui V2 Beta
Status: No status
Milestone
V2 Alpha
Development

No branches or pull requests
1 participant
@tig