Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Redraw - Non-virtual with the right set of virtual OnXXX methods #2482

Closed
tig opened this issue Apr 3, 2023 · 1 comment
Closed

Refactor Redraw - Non-virtual with the right set of virtual OnXXX methods #2482

tig opened this issue Apr 3, 2023 · 1 comment
Labels
v2 For discussions, issues, etc... relavant for v2

Comments

@tig
Copy link
Collaborator

tig commented Apr 3, 2023 •
edited
Loading

In v2, i'd like us to revisit how Redraw and the related events are structured. I started this in my View2 PR...

* `Redraw` is mis-named. It should just be `Draw` (it also shouldn't take a `Bounds` because implementors can just use `this.Bounds`; this is a cause of a bunch of bugs BTW).

* `Draw` should simply call
  
  * `OnDraw`
  * `OnDrawFrames`
  * `OnDrawContent`
  * `OnDrawContentComplete`

Each of those invokes an event and each is cancellable (except OnDrawContentComplete).

@tig I agree with this scenario, but Draw mustn't be virtual to avoid derived class not calling the OnDraw, OnDrawFrames, OnDrawContent and OnDrawContentComplete. Maybe protected. What do you think?

Originally posted by @BDisp in #2479 (comment)
@tig tig added the v2 For discussions, issues, etc... relavant for v2 label Apr 3, 2023
This was referenced Apr 3, 2023
Merged
Merged
@tig tig moved this to 🆕 New in Terminal.Gui V2 Beta Apr 6, 2023
@tig tig mentioned this issue Apr 13, 2023
Merged
8 tasks
@tig tig moved this from 🆕 New to 🔖 Ready in Terminal.Gui V2 Beta Apr 25, 2023
@tig tig mentioned this issue Apr 25, 2023
Merged
8 tasks
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Apr 27, 2023
@BDisp
Fixes gui-cs#2482. Refactor Redraw - Non-virtual with the right set o…
3f2a459 
…f virtual OnXXX methods.
@BDisp BDisp mentioned this issue Apr 27, 2023
Merged
8 tasks
tig added a commit that referenced this issue May 4, 2023
@BDisp @tznind @tig
Fixes #2482. Refactor Redraw - Non-virtual with the right set of virt…
ea24de3 
…ual OnXXX methods. (#2577)

* Fixes #2482. Refactor Redraw - Non-virtual with the right set of virtual OnXXX methods.

* Change documentation comments.

* Fixes #2575 - TableView to use interface instead of System.Data.DataTable (#2576)

* WIP: Add ITableDataSource

* WIP: Refactor TableView

* WIP: Port CSVEditor

* WIP: Port TableEditor

* WIP: Port MultiColouredTable scenario

* Fix bug of adding duplicate column styles

* Update tests to use DataTableSource

* Tidy up

* Add EnumerableTableDataSource<T>

* Add test for EnumerableTableDataSource

* Add test for EnumerableTableDataSource

* Add code example to xmldoc

* Add ProcessTable scenario

* Rename ITableDataSource to ITableSource and update docs

* Rename EnumerableTableDataSource to EnumerableTableSource

* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!

* Fix scroll resetting in ProcessTable scenario

* Fix unit tests by setting Frame to same as Bounds

* Document why we have to measure our data for use with TableView

---------

Co-authored-by: Tig Kindel <[email protected]>

* Fixes #2582 - Refactors FileDialog for cleaner data model (#2583)

* WIP: Add ITableDataSource

* WIP: Refactor TableView

* WIP: Port CSVEditor

* WIP: Port TableEditor

* WIP: Port MultiColouredTable scenario

* Fix bug of adding duplicate column styles

* Update tests to use DataTableSource

* Tidy up

* Add EnumerableTableDataSource<T>

* Add test for EnumerableTableDataSource

* Add test for EnumerableTableDataSource

* Add code example to xmldoc

* Add ProcessTable scenario

* Rename ITableDataSource to ITableSource and update docs

* Rename EnumerableTableDataSource to EnumerableTableSource

* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!

* Fix scroll resetting in ProcessTable scenario

* Fix unit tests by setting Frame to same as Bounds

* Document why we have to measure our data for use with TableView

* WIP: Simplify FileDialogs use of TableView

* WIP start migrating sorter

* WIP new filedialog table source mostly working

* WIP remove sorter class

* Refactor GetOrderByValue to be adjacent to GetColumnValue

* Fix collection navigator back so it ignores icon

* Fix unit tests

* Tidy up

* Fix UseColors

* Add test for UseColors

---------

Co-authored-by: Tig Kindel <[email protected]>

* Fixes #2196. TextView: Setting Text places cursor at beginning, unlike TextField (#2572)

* Fixes #2196. TextView: Setting Text places cursor at beginning, unlike TextField

* Change all private members to have the _prefix.

* Renamed local member to prevLayoutStyle.

* Helper function for SetNeedsDisplay.

* Fixes #2569. Borders scenarios needed to be refactored. (#2570)

* Fixes #2569. Borders scenarios needed to be refactored.

* Fix border title with width equal to 4 and thickness top grater than 1.

* Improves border manipulation on borders scenarios.

* Prevents null value on the margin, border and padding thickness on the border scenarios.

* Remove NStack using dependence and fix prior commit.

* Refactoring the Frames scenario.

* Deleted borders scenarios.

* I did not realize that it was changed to SetSubViewNeedsDisplay.

* Re-layout; fixed colorpicker; fixed radio group

* Remove Thickness.IsEmpty as requested.

* Change the Frames scenario as requested.

---------

Co-authored-by: Tig Kindel <[email protected]>

* Builds CollectionNavigator support into UI Catalog for TableView (#2584)

* Builds collectionnav support into UI cat for TableView

* Fixes keyboard mapping

* MultiSelect = false for TableView

* MultiSelect = false doesn't unbind ctrl-a

* Fixes #2581 Refactor CollectionNavigator so it supports TableView (#2586)

* Refactor CollectionNavigator to a base and a collection implementation

* Refactor CollectionNavigatorBase to look for first match smartly

* Add TableCollectionNavigator

* Make TableCollectionNavigator a core part of TableView

* Fix bad merge

* Added tests for tableview collection navigator

* Add FileDialogCollectionNavigator which ignores . and directory separator prefixes on file names

* whitespace fixes

---------

Co-authored-by: Tig <[email protected]>

* Resolving merge conflicts.

* Fix merge errors.

* Fix merge errors.

* Add Command.Accept and snap to the selected glyph when ShowHorizontalScrollIndicator change to true.

* Reformat.

* Reformat again.

---------

Co-authored-by: Thomas Nind <[email protected]>
Co-authored-by: Tig Kindel <[email protected]>
@tig
Copy link
Collaborator Author

tig commented Dec 17, 2023

This was addressed.

@tig tig closed this as completed Dec 17, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Terminal.Gui V2 Beta Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2 For discussions, issues, etc... relavant for v2
Projects
No open projects
Terminal.Gui V2 Beta
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tig