Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindDeepestView should be a public static method on the View class. #2462

Closed
BDisp opened this issue Mar 29, 2023 · 3 comments
Closed

FindDeepestView should be a public static method on the View class. #2462

BDisp opened this issue Mar 29, 2023 · 3 comments
Labels
design Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...) v2 For discussions, issues, etc... relavant for v2

Comments

@BDisp
Copy link
Collaborator

BDisp commented Mar 29, 2023

@tig, @tznind do you agree with me about this? I'll need this in the ComboBox when receiving MouseEvent through the RootMouseEvent. If you don't agree I need to make it internal static in the Application class. But I think this method would be a very important helper to handle with views on the fly managed by others views. I only will advance after your feedback. Thanks.

@tznind
Copy link
Collaborator

tznind commented Mar 29, 2023

Makes sense to me. Theres only one console so the ability to point at a row/col and find the View under it is very nice.

@tig
Copy link
Collaborator

tig commented Mar 29, 2023

Please hold off with a PR for this until I'm done with #2361 - I've made changes to these APIs and it'll be merge conflict heck.

I'm getting really close!

I am not sure it needs to be exposed publicly. I'd like to dive in deeper to see if there's another part of the API that could be exposed that will let combo box do what you want. I also don't think it's well-named or designed as an API. For example, I had to stare at it for a long time to figure out what the x and y coordinates were relative to.

I do agree it should be on View and not Application.

@tig tig added v2 For discussions, issues, etc... relavant for v2 design Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...) labels Mar 31, 2023
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Apr 3, 2023
@BDisp
Copy link
Collaborator Author

BDisp commented Apr 3, 2023

Sorry @tig, I couldn't wait more time because I needed it for the #2479.

@tig tig closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues regarding Terminal.Gui design (bugs, guidelines, debates, etc...) v2 For discussions, issues, etc... relavant for v2
Projects
None yet
Development

No branches or pull requests

3 participants