Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests? #10

Open
zeke opened this issue Oct 23, 2016 · 2 comments
Open

Tests? #10

zeke opened this issue Oct 23, 2016 · 2 comments

Comments

@zeke
Copy link

zeke commented Oct 23, 2016

This project looks pretty cool! Does it have tests? The package.json suggests that it does, but I don't see any test files...

CacheP2P/package.json

Lines 66 to 69 in ac03daa

"test": "standard && node ./bin/test.js",
"test-browser": "zuul -- test/*.js test/browser/*.js",
"test-browser-headless": "zuul --electron -- test/*.js test/browser/*.js",
"test-browser-local": "zuul --local -- test/*.js test/browser/*.js"

@guerrerocarlos
Copy link
Owner

Yep, still doesn't have any tests :(

I know tests are super important, any contributor that could help with creating and adding them, it would be greatly appreciated, I can't add them myself for now.

@deckar01
Copy link

It looks like the test runner mentioned in the test script is zuul, which should be good for unit testing the constructor and events. Not sure what unit testing library you prefer. Jasmine has been great to work with.

It would be nice to have integration tests that spin up a static server and multiple browser clients, then makes assertions about how many requests actually hit the server. Selenium seems like a good fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants